Skip to content

fix(lib-node): destroy streamed error response body to avoid socket leak #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BatLeDev wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

fix(lib-node): destroy streamed error response body to avoid socket leak #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/node/axios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ export function axiosBuilder (opts: CreateAxiosDefaults = {}, beforeInterceptors
delete error.response.request
error.response.config = { method: error.response.config.method, url: error.response.config.url, data: error.response.config.data }
if (error.response.config.data && error.response.config.data._writableState) delete error.response.config.data
if (error.response.data && error.response.data._readableState) delete error.response.data
// destroy() a streamed error body before dropping it, else its socket leaks
if (error.response.data && error.response.data._readableState) { error.response.data.destroy(); delete error.response.data }
let messageText = error.response.statusText
if (error.response.data) {
messageText = typeof error.response.data === 'string' ? error.response.data : JSON.stringify(error.response.data)
Expand Down