feat(ui): show log extra to superadmins#29
Open
BatLeDev wants to merge 1 commit into
Open
Conversation
BatLeDev
force-pushed
the
feat-logs-extra-superadmin
branch
3 times, most recently
from
7a1c147 to
fd4e9ec
Compare
Add an admin-only "view extra" toggle on log lines that reveals the log's extra payload as formatted JSON, with a copy-to-clipboard button. Visible only when the user is in adminMode and the log carries extra.
BatLeDev
force-pushed
the
feat-logs-extra-superadmin
branch
from
fd4e9ec to
06bdf01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show the log
extrafield to superadmins (admin mode): a "View extra" button expands a panel with the formatted JSON and a copy-to-clipboard button. Adds the required Vite icons.Why: Playwright had bumped itself to 1.60 (requiring a newer Chromium) — pin it back to 1.59.1. Playwright reporter switched to
dot.Regression risks:
log.vueroot element changed (d-flex text-breakmoved one level down under a new root<div>) — verify layout wherever the component is mounted.adminModeUI gate, which is not a security boundary: if the API returnslog.extrato all roles, a non-superadmin can read it via the network. Confirm whether extra should be filtered server-side.copyExtrahas notry/catcharoundnavigator.clipboard.writeText(unhandled rejection in non-secure contexts).