Refactor site#493
Conversation
✅ Deploy Preview for strchive canceled.
|
|
@vincerubinetti would it be helpful to add a |
|
We also added a new field to the locus pages since you started this PR. Something like this is needed: |
I added references |
That seems good for people consuming the json. For me, it doesn't make much of a difference since I have to keep a running list of the references I've extracted from the fields anyway. And I'm thinking it makes sense for me to use my personal lists rather than the
Added a full width box after mechanism.
Changed. What are your thoughts on just making all tables downloadable by default, and making the download button part of the standard controls (and moving all the controls to the top), e.g.:
Changed |
I think this is a good idea. Let me know if you'd like me to add a merge commit or rebase to re-align this branch with main. |
|
I've already done a merge commit that updates everything outside |
hdashnow
left a comment
There was a problem hiding this comment.
This looks good to me. Let me know if it's ready to merge.
|
I tested it pretty thoroughly and it all seems good to me. Ready for merge. |


Description
This is a very large change that affects basically everything in the
/sitefolder. When I first scaffolded the site, I avoided adding extra complication since non-web-developers would be editing it. But after encountering several bugs that would've been avoided by type-safety, and accumulating a bunch of utility and one-off style classes, I wanted to just upgrade the code base to modern best practices, even if it makes changes a bit more difficult for others.Unfortunately, we should review the entire site page by page to make sure nothing has broken.
I did make some opinionated changes that may end up being reverted:
If you have any questions or would like an in-person walkthrough of these changes, lmk.
Major Changes
Checklist
CITATION.cff, format X.Y.Z. If any major changes, increment Y. If only minor changes, increment Z. If the breaking change (rare), increment X.