Fix prune calibration with cache token usage#296
Open
romy651 wants to merge 2 commits into
Open
Conversation
Owner
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes prune calibration when provider usage includes prompt-cache detail fields that are not directly comparable with the active context window.
The pruner now prefers the provider-reported
usageMetadata.input_tokensfor calibration and skips calibration for turns where the reported input is clearly not comparable, such as Bedrock cache-artifact turns with tinyinput_tokensand very large cache creation/read detail fields.Root Cause
Cache detail fields can represent provider billing/cache accounting rather than the actual prompt window size. Folding those details into calibration could inflate the observed input and poison the running calibration ratio or resolved instruction overhead.
Impact
This keeps pruning budget estimates stable when prompt caching is active, while preserving raw token maps and existing provider-specific cache semantics.
Validation
npx tsc --noEmitnpx eslint src/messages/prune.ts src/specs/token-accounting-pipeline.test.tsgit diff --check HEAD^ HEADnpx jest src/specs/token-accounting-pipeline.test.tsnpx jest src/specs/summarize-prune.test.ts src/specs/token-distribution-edge-case.test.ts src/specs/thinking-prune.test.ts