feat(hitl): declare multiSelect on AskUserQuestionRequest#293
Merged
Conversation
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
multiSelect?: booleanto the SDK'sAskUserQuestionRequestinterface (src/types/hitl.ts, source fordist/types/types/hitl.d.ts).When
true, the host UI may let the user pick several options; the resultingAskUserQuestionResolution.answeris the selected optionvalues joined by", ". Omitted/false→ single-select. Only meaningful alongsideoptions.Why
LibreChat's ask-user-question feature (#14139) passes a tool input containing
multiSelectintoaskUserQuestion(). It works today only because the helper forwards the object verbatim intointerrupt(), and librechat-data-provider'sAgents.AskUserQuestionRequestmirror already declaresmultiSelect?: boolean.Declaring the field in the SDK closes the type-contract gap so a future SDK change that validates or picks declared fields cannot silently drop it.
Changes
src/types/hitl.ts: addmultiSelect?: booleanwith doc comment; updateAskUserQuestionResolution.answerJSDoc to cover the joined-values case.src/tools/__tests__/hitl.test.ts: new case assertingmultiSelectrides through theask_user_questioninterrupt payload and resumes with the", "-joined answer.Verification
jestAskUserQuestion suite: 5 passed (incl. new test).npm run build: confirmedmultiSelect?: boolean;lands in generateddist/types/types/hitl.d.ts.Related
Sibling to #292 — both stem from the LibreChat #14139 ask_user_question rollout. That PR fixes the tool-error-completion contract across interrupt/resume; this one closes the type-contract gap. No file overlap; independent.