Regression fixes

CONTRIBUTING.md

@@ -334,6 +334,29 @@ That feature list is exactly what CI's Windows vintage leg builds (`.github/work
 
 The definitive check is an actual `rustup toolchain install 1.73.0` build of that manifest; the command above is the cheap proxy that catches the wiring mistakes (wrong shim path, raw `io::Error::other` left in, unused imports).
 
+### The pipeline builds more than your machine does
+
+A green `cargo test` and a green `rb-regress run` are not a green pipeline.
+Run this before pushing:
+
+```bash
+scripts/preflight.sh
+```
+
+It runs what CI runs: `cargo test --release` (CI's test step is release, not
+debug), the MiSTer feature set (`optical` on, `native-zstd` off — anything
+touching zstd must go through `crate::rbformats::zstd_compat`, never the `zstd`
+crate directly), the Rust 1.73 vintage floor, and the doc-parity tests.
+
+**After pushing, read the job list, not the run conclusion.** Several jobs are
+`continue-on-error: true` — the MiSTer `rb-cli-mini` build among them — so they
+can fail while `gh run list` still reports the run as `success`. That hid a
+compile error for a day.
+
+```bash
+gh run view <run-id>
+```
+
 ### mrustc mis-lowers `leading_zeros` / `leading_ones` on narrow integers
 
 The PowerPC build (`rb-cli-ppc`, via mrustc's C backend — see `scripts/build-ppc.sh`)

Cargo.toml

@@ -203,7 +203,7 @@ webbrowser = { version = "1.0", optional = true }
 #   0.13.0 — `physical` / `open_physical`: reading a disc from the drive as flat
 #            cooked sectors, which is what makes DVD and Blu-ray work at all
 #            (the CD-only MMC ioctls fail on that media with ENOTTY).
-opticaldiscs = { version = "0.13.0", features = ["drives"], optional = true }
+opticaldiscs = { version = "0.15.0", features = ["drives"], optional = true }
 cd-da-reader = { git = "https://github.com/danifunker/rust-cd-da-reader", branch = "file-backend-on-1.0", optional = true }
 # In-app CD-DA playback (Optical tab). Pinned <0.20 for the
 # OutputStream::try_default / Sink::try_new API used in gui/optical_audio.rs.
@@ -251,6 +251,10 @@ flate2 = { version = "1", default-features = false, features = ["rust_backend"]
 # produces the standard LZ4 frame, interoperable with the DOS tool's liblz4.
 lz4_flex = "0.13"
 tar = "0.4"
+# Set an extracted file's mtime/atime after we write it (the plain host-fs
+# export path). Already a transitive dep via `tar` in every lockfile — this
+# just promotes it so we can call `set_file_mtime` directly.
+filetime = "0.2"
 bzip2 = "0.6"
 zip = { version = "8", default-features = false, features = ["deflate", "aes-crypto"] }
 base64 = "0.22"

README.md

@@ -685,7 +685,9 @@ PC Engine CD, CD32, GameCube, Wii, CD-i, and 3DO.
 | SGI    | Yes   | Yes  | SGI Volume Header (IRIX). 16 fixed slots; checksum recomputed on every write; geometry (`vh_dp`) preserved across edits. `rb-cli new hd sgi-efs` synthesizes a dvh + EFS-root hard disk from scratch (IRIX 5.3-6.5). |
 | AHDI   | Yes   | No (browse); writes whole tables from scratch | Atari ST / TT / Falcon hard disks. Four primary entries at 0x1C6 plus XGM extended chains, big-endian, no magic number — detection keys off the 0x1234 word-sum and plausible geometry. `rb-cli new hd atari` writes a fresh root sector with the tags you name (GEM / BGM / RAW); a GEM partition over 16 MiB is promoted to BGM, which is what TOS needs. Creating an XGM chain, and grafting in a bootable bootstrap, are future work. |
 | Sun    | Yes   | No (browse); writes whole labels from scratch | Sun disk label / SMI VTOC (SPARC Solaris / SunOS). 8 big-endian slices (magic `0xDABE`), geometry-derived offsets; the whole-disk "backup" slice is excluded from the list. Surfaces the UFS slices to the existing big-endian-SPARC UFS reader (browse / inspect / extract). `rb-cli new hd sun` writes a fresh label with the slice tags you name (`root`, `usr`, `swap`, … or a bare tag number), cylinder-aligned from `--heads` / `--sectors`, with slice 2 reserved for the whole-disk alias. Parser and writer both cross-validated against `fdisk` / `sfdisk`; editing an existing label and full-disk backup are future work. |
-| None (superfloppy) | Yes — auto-detects the filesystem at sector 0 (FAT / NTFS / exFAT / ext / XFS / JFS / UFS / ReiserFS / btrfs / SquashFS / HFS / HFS+ / APFS / Amiga SFS / Apple DOS 3.3 / CBM DOS / Atari DOS / RS-DOS / OS-9 RBF / DragonDOS / Acorn DFS / ADFS / TR-DOS / TI-99 / QDOS / Human68k / Alto BFS / Pilot/Cedar / Apple Lisa FS / …) | — | Standard floppy / disk sizes are recognised even without a partition table. Xerox Alto packs (`.pdi` / `.bfs` / CopyDisk / Salto `.dsk`), Pilot/Cedar PDIs (`fsFamily=2`), Dwarf 6085 `.zdisk` images, and tag-bearing Apple Lisa DiskCopy 4.2 / DART disks are detected by content and presented as a single browsable volume. |
+| X68k   | Yes   | No (browse); writes whole tables from scratch | Sharp X68000 SASI/SCSI hard disks — Human68k's native scheme. 16-byte header plus 8 entries at byte 2048, big-endian, no magic number. Both geometries are auto-detected: SCSI (`X68SCSI1`, table at 0x800, 1024-byte sectors) and SASI (table at 0x400, 256-byte sectors), including custom-IPL game disks. `rb-cli new hd x68k` synthesizes a bootable disk with the Sharp IPL signature and a Human68k FAT volume. |
+| DSD    | Yes   | — (fixed floppy geometry) | Double-sided Acorn DFS (`.dsd`). Not a table on the disk: the two sides are stored track-interleaved, so the reader de-interleaves them and this scheme presents them as **two** Acorn DFS partitions — side 0 at byte 0, side 1 at half the image. Edits to either side re-interleave on save. |
+| None (superfloppy) | Yes — auto-detects the filesystem at sector 0 (FAT / NTFS / exFAT / HPFS / ext / XFS / JFS / UFS / ReiserFS / btrfs / SquashFS / HFS / HFS+ / APFS / Amiga SFS / Apple DOS 3.3 / CBM DOS / Atari DOS / RS-DOS / OS-9 RBF / DragonDOS / Acorn DFS / ADFS / TR-DOS / TI-99 / QDOS / Human68k / Alto BFS / Pilot/Cedar / Apple Lisa FS / …) | — | Standard floppy / disk sizes are recognised even without a partition table. Xerox Alto packs (`.pdi` / `.bfs` / CopyDisk / Salto `.dsk`), Pilot/Cedar PDIs (`fsFamily=2`), Dwarf 6085 `.zdisk` images, and tag-bearing Apple Lisa DiskCopy 4.2 / DART disks are detected by content and presented as a single browsable volume. |
 
 The Clonezilla image format is also parsed as a source (MBR, GPT, partclone
 images, partition table sidecars) for restore — see `docs/clonezilla.md`.