IrentApp Back-end Version 1

[david-lafontant]

IrentApp Back-end Version 1

This Pull Request is the first version of the iRent App back-end.

• Creates back-end considering the project requirements
• Has no linters errors

Live Demo Link - BE
Live Demo Link - FE

Please visit the Front-end repository
Thank you in advance for your time and your advice.

[vichuge]

Hi dear student,

Good job so far!
You still need to work on some issues to prepare your project for the final evaluation, but you are almost there!

Suggested changes

Check the comments under the review.

You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better._

• As the first point, I tried to follow the instructions on the readme file, but once I use bundle install to install all gems, I tried to use rails db:setup and this error appears. I'm not sure why, if maybe I'm not following and step please clarify it on the readme file and PR description too. Thanks for this :)
  

• It looks like you got tests on the project, and good job for doing it. Because I couldn't start the DB, I wasn't able to check tests, if all are validated ignore this point, if there's some issue on the tests, please fix it. 😄

Thanks, this was the back-end part of review, on the front-end, I'all add it on the front-end PR

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

[mosesogwo]

Hi team,

Great work 👏
But I'm not able to review because setup of the application following your instructions is failing.
The rails db:setup or the rails db:create ... are failing and after manually creating a PG database - irentapp_final_capstone_development, running the migrations fails.

Can you try setting up your project on another pc apart from the one you're building on? It should help you find and resolve the issues.
Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[vichuge]

Hi dear student,

Great work on making the changes 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Guys, thanks to add the new info on the readme file about how to run the app. Now this works for me! 😄

Suggested changes

Check the comments under the review.

• From experience, I could understand that BE needs to be running on port 3000. Because this application works together with another one, is important to consider adding this kind of specifications to the readme file. Please add this info there. The readme file said what's going on when you use rails server but it doesn't say that is a requirement to use the BE on port 3000. Please consider add it 🐱

FE PR here!

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

[vichuge]

• Something interesting here. The readme file said how to run the RSpec tests, but at the same time the test folder has tests too, unfortunately, these tests have errors, but I consider this could be unnecessary because you have used tests on RSpec before. Please, consider deleting all these unnecessary tests (because on folder test, you're using another gem called mini-test, which is another test tool)to fix it, or in the best option, fix these tests, which would be better. 🐶
  

[danielufeli]

@vichuge thank you for the review and feedback, all our tests are passing see screenshot below.

[vichuge]

Hi dear student,

In my opinion, your project is ready for presentation! There is nothing else to say other than... it's time to merge it

Good luck! 🎉

Optional improvements

• As I said in the last review, at this point you have two diff folders with two diff tests, you're using RSpec and the other folder is called tests, this appears on default for rails 7 projects. At this point, the test folder (which normally uses mini-test gem for the test) has errors on the test if I run the command rails test. As an optional requirement, I kindly invite you to fix this. 🐶
  

• I could observe you add a live demo link on the project, which is excellent, now, what about if I want to run the project on my local machine? To prevent any errors for future users, you could add on the readme file that BE needs to work on port 3000 to use the FE and don't have any errors. Just to add the info on the readme file, I kindly invite you to add it there. 🐱

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.