Playwright Setup - #166
Open
danieltmbr wants to merge 9 commits into
Open
Conversation
Setup: - package.json with @playwright/test devDependency - playwright.config.ts targeting localhost:8080, serial execution, Tests/E2E/ Tests: - auth.spec.ts: unauthenticated redirects to /signin for albums/posts/notes - catalogue-editor.spec.ts: form fields, create flow, artwork state (set/clear), notes, draft persistence, duplicate alert, resource input add/remove, metadata 4xx error shows specific reason, note textarea checkbox bounds - helpers/auth.ts: session cookie injection (Apple Sign In can't be headless) - README.md: setup instructions + how to get a session cookie from browser Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Swift 6.0.3 open-source Linux build crashes (SIGSEGV) emitting IR for complex generic specialisations; 6.1 avoids the bug. AuthProvider.refresher was typed as optional despite the init never accepting nil — Xcode 16.2 enforces the unwrap at the call site. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The Linux Swift frontend crashes (Signal 11, null CreateCast) when emitting IR for a chained expression that existential-boxes a generic Command in a single pass. Affects both 6.0.3 and 6.1. Fix: break the chain into two explicit let steps and replace Self with the concrete type so the compiler resolves each piece independently. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Switch backend-tests and e2e-tests to -c release to avoid a Linux Swift compiler SIGSEGV (null CreateCast) that only triggers in debug builds of complex cross-module generic expressions. Revert the AlbumSearch workaround that broke the original code, and add -DVAPOR_TESTING to the e2e build so the /__test/login route is compiled into the release binary without requiring #if DEBUG. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Delete Tests/AppTests/AppTests.swift — it was the Vapor project template with Todo/TodoDTO references that never applied to this codebase. Make Notifications.configure catch VAPID_CONFIG errors instead of propagating them. Without VAPID_CONFIG in CI the server crashed at startup (swift_errorInMain → SIGILL), blocking both migrate and serve. Push notifications are optional; missing config now logs a warning and the app continues without them. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add a changes detection job (dorny/paths-filter) that runs only on pull_request events. Each test job now has an if: condition so it is skipped on PRs that don't touch its relevant paths: backend-tests + e2e-tests → tmbr-web/** or .github/workflows/** api-kit-tests → api-kit/** or .github/workflows/** Pushes to main always run all jobs regardless of paths, so the main branch is always fully verified after a merge. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.