Fix macOS GPG CI coverage#210
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpg-agentsockets do not exceed macOS AF_UNIX path limitsInvestigation
python-ciruns #24 and #26 failed only onmasterpush full-sweep jobs. The PR/feature-branch runs were green because macOS was excluded from the fast tier. The failing jobs were alltest-full-sweep (macos-latest, 3.9..3.13), which points to a macOS-specific pytest failure rather than the docs/parser changes themselves.The new GPG E2E test creates a
GNUPGHOME, andgpg-agentcreates sockets under that directory. macOS has a short AF_UNIX socket path limit, while pytest's default temporary directory on GitHub-hosted macOS runners lives under a long/private/var/folders/...path. This patch gives the GPG E2E test a short temp root.Verification
PYTHONPATH=src python -m pytest tests/test_gpg_e2e.py -qPYTHONPATH=src python -m pytest tests -qpython -m ruff check .python -m mypyThe pushed branch CI passed, including the new
test-fast (macos-latest, 3.13)job.