Skip to content

fix(installer): surface manage.sh stderr when Pulse install fails #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stevetr68 wants to merge 1 commit into from
Closed

fix(installer): surface manage.sh stderr when Pulse install fails #1311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Releases/v5.0.0/.claude/PAI/PAI-Install/engine/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1588,18 +1588,24 @@ async function installPulse(paiDir: string, emit: EngineEventHandler): Promise<b
await emit({ event: "progress", step: "voice", percent: 20, detail: "Installing Pulse (voice + dashboard + observability)..." });

try {
// Capture manage.sh stderr so a failed install reports the actual cause
// (e.g. missing ~/Library/LaunchAgents, sed/launchctl errors) instead of a
// generic message that sends users hunting blind.
let installStderr = "";
const installOk = await new Promise<boolean>((resolve) => {
const child = spawn("bash", [manageScript, "install"], {
cwd: pulseDir,
stdio: ["ignore", "pipe", "pipe"],
});
child.stderr?.on("data", (chunk) => { installStderr += chunk.toString(); });
const timer = setTimeout(() => { child.kill(); resolve(false); }, 30000);
child.on("close", (code) => { clearTimeout(timer); resolve(code === 0); });
child.on("error", () => { clearTimeout(timer); resolve(false); });
});

if (!installOk) {
await emit({ event: "message", content: "Pulse install command failed. Voice notifications will not be available." });
const tail = installStderr.trim().split("\n").slice(-20).join("\n");
await emit({ event: "message", content: "Pulse install command failed. Voice notifications will not be available." + (tail ? "\nmanage.sh stderr (last lines):\n" + tail : "") });
return false;
}

Expand Down