Fix: close calibration overlay when a session ends via skip#30
Open
danielkaijzer wants to merge 1 commit into
Open
Fix: close calibration overlay when a session ends via skip#30danielkaijzer wants to merge 1 commit into
danielkaijzer wants to merge 1 commit into
Conversation
App._loop checked the calibration active->inactive transition only between tick() and key handling. A session finished by skipping the last point ends inside _handle_key (skip -> _finish -> _end), after that check, so the overlay was never closed and the Tk window froze. A later restart then created a second Tk root, surfacing as "image pyimageN doesn't exist". Move the transition check to after _handle_key so it catches both the capture-completion and skip-to-finish paths. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App._loop checked the calibration active->inactive transition only between tick() and key handling. A session finished by skipping the last point ends inside _handle_key (skip -> _finish -> _end), after that check, so the overlay was never closed and the Tk window froze. A later restart then created a second Tk root, surfacing as "image pyimageN doesn't exist".
Move the transition check to after _handle_key so it catches both the capture-completion and skip-to-finish paths.