Skip to content

Update Decimal dependency to 3.x#68

Open
ccarvalho-eng wants to merge 2 commits into
danielberkompas:masterfrom
ccarvalho-eng:ccarvalho/decimal-3-support
Open

Update Decimal dependency to 3.x#68
ccarvalho-eng wants to merge 2 commits into
danielberkompas:masterfrom
ccarvalho-eng:ccarvalho/decimal-3-support

Conversation

@ccarvalho-eng
Copy link
Copy Markdown

@ccarvalho-eng ccarvalho-eng commented May 12, 2026

Pins Decimal to 3.1.0.

This keeps the package on a patched Decimal release and avoids the 3.0.0 regression noted in ericmj/decimal#228.

Verification:

  • mix test

@GRoguelon
Copy link
Copy Markdown

I would recommend to install >= 3.0.1, there is a bug in 3.0.0 which causes an infinity loop when passing Decimal.new("0.0") to Number.

Source:

@ccarvalho-eng ccarvalho-eng force-pushed the ccarvalho/decimal-3-support branch from 8eadae9 to fdc64ea Compare May 13, 2026 00:07
@ccarvalho-eng
Copy link
Copy Markdown
Author

Thanks for pointing that out. I updated the PR to pin Decimal to 3.1.0, so it avoids the 3.0.0 issue entirely. I reran mix test successfully after the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants