Fix lint error and skip S3 test when minio unavailable#92
Open
yarikoptic wants to merge 2 commits into
Open
Conversation
- Add PLC0415 to ruff ignore list since boto3 is intentionally lazy-imported to keep it an optional dependency - Skip test_yield_files_s3 when MINIO_ENDPOINT env var not set, allowing local tox runs without docker-compose Closes #78 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
bitnami/minio and minio/minio images are no longer maintained: - Bitnami deprecated free images (August 2025) - MinIO stopped publishing free Docker images (October 2025) Switch to ghcr.io/coollabsio/minio which provides automated builds from official MinIO source. Run minio as a docker step (not service) since GHA services don't support specifying commands. Use conditional to only start minio for test runs, not lint/typing/codespell. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PLC0415 to ruff ignore list since boto3 is intentionally lazy-imported to keep it an optional dependency
Skip test_yield_files_s3 when MINIO_ENDPOINT env var not set, allowing local tox runs without docker-compose
Closes lint and typing needs fixups #78