Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 46.33% 46.15% -0.19%
==========================================
Files 29 29
Lines 3984 4000 +16
==========================================
Hits 1846 1846
- Misses 2138 2154 +16 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #179, the web view will need to be aware of what domain, port, and scheme (and possibly also URL path) the user is accessing
dandidavat so it can display the same in the download instructions. This PR is a test of various ways to get this information. Performing the test involves merging & deploying this PR, accessing https://webdav.dandiarchive.org/.test and https://dandi.centerforopenneuroscience.org/.test, noting down the responses, and then deploying a new PR to revert this one.For the record, when running
dandidavlocally with the default options, accessing http://localhost:8080/.test in Safari gives the response: