Fix row height clipping and line number column font not updating#4
Draft
Copilot wants to merge 4 commits into
Draft
Fix row height clipping and line number column font not updating#4Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Co-authored-by: danaspiegel <6631+danaspiegel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix row height in table view when changing font size
Fix table row height not updating when font size changes in preferences
Mar 2, 2026
Co-authored-by: danaspiegel <6631+danaspiegel@users.noreply.github.com>
Copilot
AI
changed the title
Fix table row height not updating when font size changes in preferences
Fix table row height to dynamically size based on font metrics
Mar 2, 2026
Co-authored-by: danaspiegel <6631+danaspiegel@users.noreply.github.com>
Copilot
AI
changed the title
Fix table row height to dynamically size based on font metrics
Fix row height clipping and line number column font not updating
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At non-default font sizes, descenders were clipped and the line number column ignored font preference changes entirely.
Changes
Descender clipping:
NSTableView.rowHeightis the total row height; the usable cell drawing rect isrowHeight − intercellSpacing.height. The previous calculation didn't account for this, clipping 1px off top/bottom at default spacing. Row height now includes the intercell spacing:Line number column font:
createLineNumberColumnallocates its ownNSTextFieldCell, separate from thedataCellivar.applyTableFontonly updateddataCell, leaving the line number cell at the default font. Fix iterates all columns and updates the line number column's data cell:💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.