Skip to content

Fix row height clipping and line number column font not updating#4

Draft
Copilot wants to merge 4 commits into
masterfrom
copilot/fix-table-view-row-height
Draft

Fix row height clipping and line number column font not updating#4
Copilot wants to merge 4 commits into
masterfrom
copilot/fix-table-view-row-height

Conversation

Copilot AI commented Mar 2, 2026

Copy link
Copy Markdown

At non-default font sizes, descenders were clipped and the line number column ignored font preference changes entirely.

Changes

  • Descender clipping: NSTableView.rowHeight is the total row height; the usable cell drawing rect is rowHeight − intercellSpacing.height. The previous calculation didn't account for this, clipping 1px off top/bottom at default spacing. Row height now includes the intercell spacing:

    self.tableView.rowHeight = MAX(17.0, fontHeight + self.tableView.intercellSpacing.height);
  • Line number column font: createLineNumberColumn allocates its own NSTextFieldCell, separate from the dataCell ivar. applyTableFont only updated dataCell, leaving the line number cell at the default font. Fix iterates all columns and updates the line number column's data cell:

    for (NSTableColumn *col in self.tableView.tableColumns) {
        if ([col.identifier isEqualToString:TTLineNumberColumnIdentifier]) {
            [col.dataCell setFont:font];
            break;
        }
    }

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: danaspiegel <6631+danaspiegel@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix row height in table view when changing font size Fix table row height not updating when font size changes in preferences Mar 2, 2026
Co-authored-by: danaspiegel <6631+danaspiegel@users.noreply.github.com>
Copilot AI changed the title Fix table row height not updating when font size changes in preferences Fix table row height to dynamically size based on font metrics Mar 2, 2026
Co-authored-by: danaspiegel <6631+danaspiegel@users.noreply.github.com>
Copilot AI changed the title Fix table row height to dynamically size based on font metrics Fix row height clipping and line number column font not updating Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants