New user preference to disable Dolby Vision by whitingj · Pull Request #1644 · damontecres/Wholphin

whitingj · 2026-06-29T21:00:37Z

The PR adds a user preference to control dolby vision support in device profiles. This gives the user the ability to turn off problematic dolby vision media without relying on KnownDefects.kt to handle all permutations.

Background:
My household uses FireTV for streaming our media. I have several different models across multiple generations connected to different brands of TVs. It has been a very frustrating experience trying to get Dolby Vision media to play on those devices. I frequently get a black screen when play DV media by it various by model and TV. This seems to be a very common issue that continues to cause people problems. I tried various fixes including filtering DV codecs with mixed success (it worked on some FireTV / TV combos but not others). Since the problem varies depending on the TV and media, I thought it best to give the user a preference to disable DV compatibility and let the server transcode.

Feature Changes:

AppPreference.kt: Added the new user preference. The preference is labeled "Disable Dolby Vision" and defaults to "Off". It provides two other options "Disable All Dolby Vision" and "Disable Dolby Vision with HDR10". The first removes all Dolby Vision compatibility, when the second only removes compatibility with hybrid Dolby Vision/HDR10 media. (See Screen Shoot)
DeviceProfileService.kt: Glues up the new user preference with DeviceProfileUtils.kt.
DeviceProfileUtils.kt: In HEVC and AV1 unsupported buildSet it will apply the user preference and mark the device as incompatible.
WholphinDataStore.proto: Updates to the protobuf to store the new user preference.
strings.xml: The new strings I introduced for the prefence.

Description

Adding a new user preference to disable Dolby Vision when sending device compatibility information to the Jellyfin server.

Related issues

This is a common problem across the Jellyfin ecosystem, but there isn't a specific issue for Wholphin. My experience is the issue is FireTV (model and generation) + TV dependent + media dependent. I tested videos from https://kodi.wiki/view/Samples with the same DOVIWithHDR10 flag that worked while other movies I have with the same flag didn't work. It is a very frustrating user experience and the current work around of setting the bitrate really low to force a transcode is sub-optimal IMO as it lowers the video quality. This allows the user to maintain full quality while disabling DV.

jellyfin/jellyfin-androidtv#4021
jellyfin/jellyfin-androidtv#4892
nova-video-player/aos-AVP#1503
https://www.reddit.com/r/jellyfin/comments/12jqoxh/dolby_vision_video_not_working_on_fire_stick_4k/

Testing

FireTV 4K (gen 1) + Vizio
FireTV 4K Max (gen 1) + LG
FireTV 4K Max (gen 2) + Vizio
FireTV (gen 1) + Olevia

Screenshots

AI or LLM usage

I used Claude Code to help guide me through the unfamiliar repo and to prototype solutions. The current code in the PR is my own.

…ofiles. This gives the user the ability to turn off problematic dolby vision media without relying on KnownDefects.kt to handle all permutations. Additionally, changes were made to workflows/main.yaml and build.gradle.kts making it easier for people who fork the repo to build and have actions.

…esent.

damontecres

This PR has build script changes unrelated to the suggested feature. I will review this PR once that is fixed.

whitingj · 2026-06-30T18:43:09Z

Removed the changes to the build and github actions. Let me know if I need to make any other changes before getting a review. Thanks.

xAphex · 2026-07-10T17:57:38Z

At this point there needs to be a Dolby Vision section that includes all Dolby vision settings, or else it clutters settings.

another thing, when you select disable dolby vision with hdr10, does it direct play HDR10 or transcodes it?

damontecres

I'll admit that I'm not super familiar with Dolby Vision and all of the peculiarities with it, but I do agree that it seems accurately detecting support is difficult so this seems useful.

Thanks for the contribution!

damontecres · 2026-07-10T18:36:33Z

                summary = R.string.force_dovi_profile_7_summary,
            )

+        val DoviDeviceCompatibilityPref =


I'd like to make this an experimental setting, see #1624 for an example.

damontecres · 2026-07-10T18:39:52Z

+            when (doviDeviceCompatibilityMode) {
+                DoviDeviceCompatibilityMode.DISABLE_DOVI_ALL -> {
+                    add(VideoRangeType.DOVI.serialName)
+                    add(VideoRangeType.DOVI_WITH_HDR10.serialName)


Does DOVI_WITH_HLG and DOVI_WITH_SDR need to be considered here?

Thanks for pointing out these formats. Since the preference is disable all dolby vision, I think we should it should report the device as being incompatible with these formats (even through I haven't had a problem with it). The less restrictive option would continue to only disable the dolby vision with hdr10(+) formats.

I think reporting all of them as incompatible makes sense

damontecres · 2026-07-10T18:41:39Z

+                    add(VideoRangeType.DOVI_WITH_HDR10.serialName)
+                    if (jellyfinTenEleven) add("DOVIWithHDR10Plus")
+                }
+                else -> {}


Use exhaustive enum list instead of else so potential future changes force a compiler error.

damontecres · 2026-07-10T18:41:45Z

+                        add("DOVIWithELHDR10Plus")
                    }
                }
+                else -> {}


Same as above

damontecres · 2026-07-10T18:42:10Z

+    </string-array>
+    <string-array name="dovi_device_compatibility_mode_descriptions">
+        <item>Allow Dolby Vision media</item>
+        <item>Force transcoding by reporting the device as incompatible with all Dolby Vision media</item>


Suggested change

<item>Force transcoding by reporting the device as incompatible with all Dolby Vision media</item>

<item>Force transcoding all Dolby Vision media</item>

damontecres · 2026-07-10T18:42:36Z

+    <string-array name="dovi_device_compatibility_mode_descriptions">
+        <item>Allow Dolby Vision media</item>
+        <item>Force transcoding by reporting the device as incompatible with all Dolby Vision media</item>
+        <item>Force transcoding by reporting the device as incompatible with Dolby Vision and HDR10/HDR10+ hybrid media</item>


Suggested change

<item>Force transcoding by reporting the device as incompatible with Dolby Vision and HDR10/HDR10+ hybrid media</item>

<item>Force transcoding Dolby Vision with HDR10/HDR10+ hybrid media</item>

whitingj and others added 4 commits June 29, 2026 13:00

Actions fix to only attempt to use the extensions of the secret is pr…

fce6838

…esent.

Lint fix.

e4a253a

Merge branch 'main' into main

1ff4d2e

damontecres requested changes Jun 30, 2026

View reviewed changes

Reverting workflow and build changes

125ddbb

whitingj requested a review from damontecres June 30, 2026 18:43

damontecres requested changes Jul 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

New user preference to disable Dolby Vision#1644

New user preference to disable Dolby Vision#1644
whitingj wants to merge 5 commits into
damontecres:mainfrom
whitingj:main

whitingj commented Jun 29, 2026 •

edited

Loading

Uh oh!

damontecres left a comment

Uh oh!

whitingj commented Jun 30, 2026

Uh oh!

xAphex commented Jul 10, 2026 •

edited

Loading

Uh oh!

damontecres left a comment

Uh oh!

damontecres Jul 10, 2026

Uh oh!

damontecres Jul 10, 2026

Uh oh!

whitingj Jul 16, 2026

Uh oh!

damontecres Jul 20, 2026

Uh oh!

damontecres Jul 10, 2026

Uh oh!

damontecres Jul 10, 2026

Uh oh!

damontecres Jul 10, 2026

Uh oh!

damontecres Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	<item>Force transcoding by reporting the device as incompatible with all Dolby Vision media</item>
	<item>Force transcoding all Dolby Vision media</item>

	<item>Force transcoding by reporting the device as incompatible with Dolby Vision and HDR10/HDR10+ hybrid media</item>
	<item>Force transcoding Dolby Vision with HDR10/HDR10+ hybrid media</item>

Uh oh!

Conversation

whitingj commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Testing

Screenshots

AI or LLM usage

Uh oh!

damontecres left a comment

Choose a reason for hiding this comment

Uh oh!

whitingj commented Jun 30, 2026

Uh oh!

xAphex commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

damontecres left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

whitingj commented Jun 29, 2026 •

edited

Loading

xAphex commented Jul 10, 2026 •

edited

Loading