Add option to never automatically hide controls#1637
Draft
damontecres wants to merge 2 commits into
Draft
Conversation
|
Suggestion, maybe better to add a "Never" toggle under the slider which disables the slider when enabled. I think this would be better than having to drag the slider all the way past 15 seconds to disable auto hide, considering the slider moves in 0.1 second increments. This also makes it clear that there is a "Never" option; hiding the "Never" option behind 15 seconds might make it unknown to (most) users who don't know that it exists. |
Owner
Author
I've been trying to avoid adding more and more toggles as much as I can. The settings pages are so cluttered as is. But I do agree that having it at >15s is awkward and tough to find. Let me think more on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an option to disable automatically hiding playback controls. It can be enabled by by moving higher than 15 seconds.
Also, a slight UI tweaks to use a fixed width for the slider preference labels. This prevents the slider bar from changing size if the label becomes shorter or longer (eg "9 seconds"=>"10 seconds").
Related issues
Closes #1629
Testing
Emulator
Screenshots
N/A
AI or LLM usage