Skip to content

Add a preference option to disable hardware audio offloading#1564

Open
Nehereus wants to merge 8 commits into
damontecres:mainfrom
Nehereus:main
Open

Add a preference option to disable hardware audio offloading#1564
Nehereus wants to merge 8 commits into
damontecres:mainfrom
Nehereus:main

Conversation

@Nehereus

Copy link
Copy Markdown

Description

By default, Wholphin plays music with hardware audio offloading enabled. This delegates audio decoding to the device's hardware DSP, making playback stability highly dependent on the manufacturer's system audio implementation. On certain hardware (such as my TCL TVs, e.g., the Chinese Model Q9L Pro), this implementation causes music playback to hang indefinitely at 0 seconds.

Related issues

#1372

Testing

Tested on a TCL TV (Q9L Pro):

  • Some musics playback hangs at 0s with offloading enabled.
  • Disabling audio offloading fixes the issues for all medias.

Screenshots

IMG_9486

AI or LLM usage

Developed in pair with Gemini and human-reviewed, tested.

Copilot AI review requested due to automatic review settings June 11, 2026 17:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@devwebit4u

Copy link
Copy Markdown

Having the exact same problem with my TCL C81K. Hope that this will fix the issue.

@damontecres damontecres left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I'd just like to move this setting to experimental and you'll need to clean up some code after merging/rebasing main.

Comment thread app/src/main/java/com/github/damontecres/wholphin/preferences/AppPreference.kt Outdated
Comment thread app/src/main/java/com/github/damontecres/wholphin/services/PlayerFactory.kt Outdated
Comment thread app/src/main/res/values/strings.xml Outdated
@Nehereus
Nehereus marked this pull request as draft July 13, 2026 02:15
@Nehereus
Nehereus marked this pull request as ready for review July 13, 2026 02:22

@damontecres damontecres left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes needed

Comment thread app/src/main/res/values/strings.xml Outdated
Comment thread .gitignore Outdated
Co-authored-by: Damontecres <damontecres@gmail.com>

@damontecres damontecres left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will merge once CI passes

@damontecres damontecres added enhancement New feature or request playback Related to media playback labels Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request playback Related to media playback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants