Skip to content

Updates to playback controls #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damontecres merged 4 commits into from
May 16, 2026
Merged

Updates to playback controls #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4adb10
Better transition between controls & marker row
damontecres May 15, 2026
fc34c3a
Reduce playback button size
damontecres May 15, 2026
ffa0ecb
Refactor playback page to use state flow
damontecres May 16, 2026
9d7d651
Move more state to PlaybackViewModel
damontecres May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions app/src/main/java/com/github/damontecres/stashapp/ui/components/playback/PlaybackControls.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ fun PlaybackControls(
intervals = seekBarIntervals,
modifier =
Modifier
.padding(vertical = 8.dp)
.padding(vertical = 4.dp)
.fillMaxWidth(.95f),
)
Row(
Expand Down Expand Up @@ -555,6 +555,9 @@ fun PlaybackButtons(
}
}

private val buttonPadding = 4.dp
private val buttonSize = 40.dp

@Composable
fun PlaybackButton(
@DrawableRes iconRes: Int,
Expand All @@ -573,11 +576,11 @@ fun PlaybackButton(
containerColor = AppColors.TransparentBlack25,
focusedContainerColor = selectedColor,
),
contentPadding = PaddingValues(8.dp),
contentPadding = PaddingValues(buttonPadding),
modifier =
modifier
.padding(8.dp)
.size(56.dp, 56.dp)
.padding(buttonPadding)
.size(buttonSize)
.onFocusChanged { onControllerInteraction.invoke() },
) {
Icon(
Expand Down Expand Up @@ -607,11 +610,11 @@ fun PlaybackFaButton(
containerColor = AppColors.TransparentBlack25,
focusedContainerColor = selectedColor,
),
contentPadding = PaddingValues(8.dp),
contentPadding = PaddingValues(buttonPadding),
modifier =
modifier
.padding(8.dp)
.size(56.dp, 56.dp)
.padding(buttonPadding)
.size(buttonSize)
.onFocusChanged { onControllerInteraction.invoke() },
) {
Box(
Expand All @@ -621,7 +624,7 @@ fun PlaybackFaButton(
text = stringResource(iconRes),
fontFamily = FontAwesome,
color = MaterialTheme.colorScheme.onSurface,
fontSize = 28.sp,
fontSize = 22.sp,
modifier = Modifier.align(Alignment.Center),
)
}
Expand Down
Loading
Loading