Fix src/Makefile being wrongly overwritten by src/sman/Makefile#22
Open
binghe wants to merge 1 commit into
Open
Fix src/Makefile being wrongly overwritten by src/sman/Makefile#22binghe wants to merge 1 commit into
binghe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
src/Makefile.pamphlet, the following chunk of code extracts anotherMakefilefrombookvol6.pamphletintosrc/smanand execute the new Makefile for building some executions (spadclient,session, etc.):Unfortunately, the command
cd smanfailed, because the sub-directorysrc/smandoesn't exist. But this is not a fetal issue, as the next shell commands still successfully extracted the new Makefile and execute it, just it is directly put intosrc/and overwrote the existing one. The final resulting Axion build didn't miss anything which should be built but not, just the toplevel platform-specificMakefile.SYSnow becomes invalid, because the callingsrc/Makefileis not the correct one. A simple solution is to domkdir -p smanbeforecd sman.