feat: e-ink borders for cards and drawer items - #1
Open
dalekirkwood wants to merge 1 commit into
Open
Conversation
When e-ink mode is on: - Bookmark cards: black border, white background, no shadow - Drawer items: black outline when selected instead of gray background - Card image crossfade disabled (avoids ghosting on load) Uses a LocalEInkMode CompositionLocal to avoid threading the boolean through every composable parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Secondary visual refinements for e-ink mode. Stacked on top of jensomato#178 (which targets jensomato/ReadeckApp develop).
When e-ink mode is on:
Implementation
Uses a
LocalEInkModeCompositionLocal to avoid threading the boolean through every composable parameter. Provided once at the app root, read wherever needed.Theme.kt:val LocalEInkMode = staticCompositionLocalOf<Boolean> { false }MainActivity.kt: wraps app inCompositionLocalProviderBookmarkCard.kt: conditional border, elevation, container colorBookmarkListScreen.kt: newEInkAwareNavigationDrawerItemwrapper with border on selected itemsDepends on
jensomato#178 must merge first. This branch is based on
feat/eink-mode.Test plan