fix(cli): accept --content/--text for engram store; clearer error#7
Merged
Conversation
Transcript analysis showed the model frequently guessed `engram store --content "…"` (or --text) — natural, since `update` uses --content — and hit a silent "store: missing content" failure, leaving memories unsaved. Accept content positionally OR via --content/--text, and make the missing-content error show the correct invocation forms. Adds CLISmokeTests covering all three forms plus the helpful-error path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
engram storeonly accepted content positionally, but transcript analysisacross ~1800 sessions showed the model frequently reaches for
engram store --content "…"(or--text) — a natural guess, sinceupdateuses
--content. Those attempts failed silently withstore: missing content,leaving memories unsaved. This is a concrete, evidenced cause of the
"nothing gets stored" problem (≥17 such failures in transcripts).
Changes
--content/--text.missing contenterror with one that shows the correctinvocation forms.
CLISmokeTests: assert all three forms store + round-trip via fetch, and thatthe content-less error is actionable.
Verification
swift build --product engram+swift testgreen (102 tests, incl. the newcliStoreAcceptsContentAndTextFlagsandcliStoreWithoutContentFailsWithHelpfulMessage).Context
Part 1 of the "are memories actually being stored?" investigation. Part 2 (a
model-in-the-loop eval measuring how reliably the agent decides to store) is
separate, upcoming work.
🤖 Generated with Claude Code