Add pattern matching type inference#103
Merged
Merged
Conversation
c3217b5 to
13c5057
Compare
12f9d0d to
b4744db
Compare
Pattern matching was not supported by MethodRay, causing it to silently skip type inference for matched variables. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
b4744db to
3ad4448
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Pattern matching was not supported by MethodRay, causing it to silently skip type inference for matched variables.
Changes
CaseMatchNodeprocessing with support for all pattern types: capture, array, hash, find, alternation, pinned variable/expression, guard (if), and literal{ name: }binding viaImplicitNodeunwrappingApi::User => u) viaextract_constant_path**restto read fromHashPatternNode.rest()instead ofelements()install_local_var_writefor consistent ChangeSet edge propagationUnlessNodeguard branch (Ruby does not supportunlessguards incase/in)Checked
cargo test --lib(44 passed)bundle exec ruby -Ilib -Itest test/pattern_matching_test.rb(18 passed)