Add constant type inference support#102
Merged
Merged
Conversation
dak2
changed the title
dak2
force-pushed
the
feature/v020-constants
branch
from
3faec5a to
d3a2018
Compare
dak2
changed the title
dak2
force-pushed
the
feature/v020-constants
branch
3 times, most recently
from
bd734e5 to
ca7e32c
Compare
MethodRay did not track user-defined constants, so type errors on constant references (e.g., `MAX.upcase` where `MAX = 100`) were silently missed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dak2
force-pushed
the
feature/v020-constants
branch
from
ca7e32c to
18acef4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MethodRay did not track user-defined constants, so type errors on constant references (e.g.,
MAX.upcasewhereMAX = 100) were silently missed.Changes
install_constant_write/install_constant_readinvariables.rswith namespace-aware lookup (current scope → parent scopes → top-level)constantsHashMap toGlobalEnvfor qualified constant name → VertexId mappingConstantWritevariant toNeedsChildKindand dispatchConstantWriteNodeConstantReadNodedispatch to check constant table before falling back to Singleton typefinish_ivar_write/finish_local_var_writewrappers, callinstall_*directlyChecked
cargo test --lib— 52 tests pass🤖 Generated with Claude Code