Fix uninitialized @@var reads silently skipping downstream type checking#101
Merged
Conversation
dak2
changed the title
dak2
changed the title
@@var reads silently skipping downstream type checking
dak2
force-pushed
the
fix/class-variable-review-improvements
branch
from
96ca50d to
2aa4994
Compare
…cking When `@@var` was read before being written, install_class_var_read returned None, which propagated through the ? operator and caused the entire method call chain (e.g. @@data.upcase) to be silently dropped from type checking — producing neither errors nor warnings. Fall back to a nil vertex on uninitialized reads, matching the existing global variable ($var) pattern, so downstream method calls are always type-checked. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dak2
force-pushed
the
fix/class-variable-review-improvements
branch
from
2aa4994 to
13cc821
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #99 introduced class variable (
@@var) type tracking, but it has a issue that uninitialized@@varreads returnedNotHandled, silently skipping all downstream method call type checkingChanges
@@varreads (matching the global variable pattern) so method chains like@@data.upcaseare always type-checked.expect()with defensiveif let Somepattern inset_class_var_in_classfor consistencytest_class_variable_write_before_readto correct "No Error" section@@varisolation, module-scope resilienceChecked
cargo test --libruby -Ilib -Itest test/class_variable_test.rb🤖 Generated with Claude Code