feat(format): add --format-always flag - #162
Open
JamyDev wants to merge 5 commits into
Open
Conversation
Signed-off-by: Jamy Timmermans <jamy@uber.com>
Owner
|
Do you mean that you have codes without import block so that you can not disable |
Author
|
I have configured gci as the default formatter for my project. Which also means configuring it as the default format on save in my IDE. Right now, the formatting doesn't happen for files that don't have an import block, since gci just skips those. Adding this flag basically makes it fall back to gofmt fir any files without imports so the rest of the file is properly formatted. |
Owner
|
@JamyDev please update README then we can make it land. |
Signed-off-by: Jamy Timmermans <jamy@uber.com>
Author
|
updated! |
daixiang0
reviewed
Jul 18, 2023
daixiang0
reviewed
Jul 18, 2023
Signed-off-by: Jamy Timmermans <jamy@uber.com>
daixiang0
reviewed
Jul 18, 2023
Signed-off-by: Jamy Timmermans <jamy@uber.com>
Owner
|
@JamyDev seems still conflict :( |
Author
|
Fixed @daixiang0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the option to always run
goFormat.Sourceeven if there are no imports.Justification:
Currently we have to run 2 formatters to make sure everything is properly formatter (gofmt and gci). Yet any fime that has imports and gets formatted by gci, doesn't actually need to get ran through gofmt. This eliminates this double tool problem.