Add Find/Replace In Selection#1045
Open
saberoueslati wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
I returned this PR to being a draft to work on the In Selection for the recently added Mark Tab, will make it ready for review again as soon as I finish that |
5f51233 to
1825409
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #856
This PR adds an In selection option to the Find/Replace dialog so users can limit find, count, find-all, replace, and replace-all operations to the selected text range.
The selection range is captured when the checkbox is enabled, so later cursor movement or selection changes do not accidentally expand the search scope.
Additionally, Mark All is constrained to the captured selection range when In selection is active, and Purge for each search clears highlights only within that range rather than the entire document.
Changes Made
In selectioncheckbox to the Find/Replace dialog.In selectionis checked.Testing
Manual test plan :
TestPlan-FindReplaceInSelection.md
Coverage includes:
Basic manual test below :
Screencast.from.2026-05-06.00-46-52.webm
Edit :
Just added the In Selection option for the Mark Tab, updated the description, changes made and testing section accordingly
Basic manual test of the In Selection feature in the Mark tab below :
Screencast.from.2026-05-27.18-24-21.webm