Export getCurrentDay and improve current day calculation for championship header#89
Open
dai wants to merge 1 commit into
Open
Export getCurrentDay and improve current day calculation for championship header#89dai wants to merge 1 commit into
dai wants to merge 1 commit into
Conversation
Deploying o-sumo with
|
| Latest commit: |
6ab1f3f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3697fc8d.o-sumo.pages.dev |
| Branch Preview URL: | https://codex-fix-changes-not-reflec-v081.o-sumo.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
getCurrentDayinapp/page.tsxwhich computes the current basho day usingresultDayswithstatus === 'published', aresultUpdatedAtreference date to considerisoDate-bounded result days, andtoday.makuuchi.day, then returns the maximum of those values.Homecomponent to use the newgetCurrentDayresult forcurrentDayand theshowChampionshipRaceflag.app/page.test.tsxto importgetCurrentDayand add a testshows championship header as day 14 when day 14 has startedthat asserts the championship headings use the computed day.Testing
app/page.test.tsxwhich exercised the newgetCurrentDaybehavior and the new championship header test, and they passed.Codex Task