Skip to content

Tests | Add repo-server source matrix#450

Open
dag-andersen wants to merge 3 commits into
mainfrom
attempt-at-making-more-tests
Open

Tests | Add repo-server source matrix#450
dag-andersen wants to merge 3 commits into
mainfrom
attempt-at-making-more-tests

Conversation

@dag-andersen

@dag-andersen dag-andersen commented Jun 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add a repo-server source matrix organized around the decisions buildManifestRequestForSource makes: STR/TYP/REACH/REF/REQ/TRV/NEG
  • Add coverage for strategy selection, source-type detection, file reachability, ref handling, request invariants, app-of-apps traversal, and negative cases
  • Add known-bug repro tests for remaining uncovered rows, skipped by default unless RUN_KNOWN_BUG_TESTS=1

Why this helps

  • Turns the repo-server render path into an explicit compatibility contract instead of relying on user-reported edge cases
  • Pins regressions for recently fixed repo-server-api issues
  • Documents repo-server behavior discovered from the Argo CD implementation
  • Leaves executable repros for the known gaps so each can be enabled when fixed

Tests

  • make run-unit-tests
  • golangci-lint run ./pkg/reposerverextract/...
  • RUN_KNOWN_BUG_TESTS=1 go test -run 'TestSourceMatrix_(TYP5|REACH5|REACH6|REACH11|REF13)' ./pkg/reposerverextract/... -v - confirms 5 opt-in repros fail

@dag-andersen dag-andersen changed the title Tests | Restructure repo-server source matrix Tests | Add repo-server source matrix Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant