Fix | Render same-repo refs with remote Helm charts#442
Merged
Conversation
92f98cc to
e4fa21a
Compare
|
FWIW tested this locally and it looks like it fixes the issue I ran into — ty! Details (built from this branch with
|
e4fa21a to
0a03109
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$refvalue files live in the same PR repository.refs, rewrite$refvalue files to relative paths, and stream the temp tree to repo-serverCloses #441
Testing
go build ./...go vet ./...go test ./pkg/reposerverextract/...make run-unit-tests