Skip to content

Fix | Clean finalizers before stale app deletion#439

Merged
dag-andersen merged 1 commit into
mainfrom
fix/stale-app-finalizer-cleanup
Jun 7, 2026
Merged

Fix | Clean finalizers before stale app deletion#439
dag-andersen merged 1 commit into
mainfrom
fix/stale-app-finalizer-cleanup

Conversation

@dag-andersen

Copy link
Copy Markdown
Owner

Summary

  • Clean all known Argo CD application finalizers before deleting stale preview apps
  • Share finalizer cleanup logic between single-app and batch deletion paths
  • Avoid extra GET calls in batch cleanup by using already-listed application objects

Testing

  • make run-unit-tests

@dag-andersen dag-andersen merged commit 85d7fb0 into main Jun 7, 2026
3 checks passed
@dag-andersen dag-andersen deleted the fix/stale-app-finalizer-cleanup branch June 7, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant