Models#13
Open
EricBoittier wants to merge 2 commits into
Open
Conversation
… Preproc and descriptor directives are available
Collaborator
|
Hey could you test if you still get the same numbers with all the new changes that happened in the meantime? I agree it might make sense to break down the script into smaller parts. @daenuprobst what do you think? tagging you because modifying the bench marking script is obviously important :) |
Owner
|
Hey... definitely makes sense to breaking up the script (or maybe even a separate branch for now?). @EricBoittier, could you confirm whether the results are still the same? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little bit of an ambitious pull request... It would be nice to have more structure and a more compact main.py.
Sorry if I missed any recent changes; I ran the benchmark and can reproduce the results (I made gzip and smiles the defaults).
I can break it up into smaller pull requests. Feel free to let me know if you would rather try something else.