Conversation
yoon-junseo
approved these changes
Apr 17, 2024
yoon-junseo
left a comment
yoon-junseo
left a comment
Contributor
There was a problem hiding this comment.
좋다
UI만 정의해서 내보낼 때 createPortal로 묶기만 하면 동작은 알아서 제공해주는거네
앞으로 파일은 지금 구조처럼 폴더 하위에서 index.ts index.tsx로 내보내주는거로 할까 ??
| "name": "@daehwahap/global-components", | ||
| "version": "0.0.1", | ||
| "private": true, | ||
| "devDependencies": { |
Contributor
There was a problem hiding this comment.
요런식으로 packageManager 명시해줘도 좋을듯 !
Contributor
There was a problem hiding this comment.
요기는 8e63da2
context 생성 관련 util을 추가해줘서 얘로 바꿔도 되겠다
바꾸는건 내가 해둘게
| import { createPortal } from '@daehwahap/global-components/src/utils' | ||
| import { useEffect } from 'react' | ||
| import { | ||
| GlobalComponentContextProvider, |
Contributor
There was a problem hiding this comment.
이거 미사용인데 남아있다
vscode에서는 lint가 안 잡혀서 전체적으로 봐야겠다
요런건 우선 냅두고 내가 한번에 lint랑 ts 전체적으로 봐볼게
|
|
||
| type HOCProviderProps = { children: ReactNode } | ||
|
|
||
| const HOCProvider = ({ children }: HOCProviderProps) => { |
Contributor
There was a problem hiding this comment.
아래처럼 해도 되겠다
Suggested change
| const HOCProvider = ({ children }: HOCProviderProps) => { | |
| const HOCProvider = ({ children }: PropsWithChildren) => { |
Comment on lines
+12
to
+14
| <div style={{ position: 'absolute' }}> | ||
| <Toast.Portal /> | ||
| </div> |
Contributor
There was a problem hiding this comment.
이쪽에서 hydration error 발생하는데 createPortal에서 createElement 해주는 부분 때문인가
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
우선 web에 토스트올려놨는데 애니매이션이나, 코드는 완성은 아님 (만족스럽지 않음..)
근데 대충 코드 흐름은 볼 수 있어서 pr올려둠!