fix!: have nonce checker make decisions on absence of nonces in signature#107
Merged
Merged
Conversation
mariusor
commented
May 12, 2026
…resence of the nonce in the signature parameters
mariusor
force-pushed
the
change-nonce-checker-interface
branch
from
9c5d373 to
0a23c3b
Compare
Contributor
Author
|
@dadrus is this missing anything before it can be merged? |
Owner
|
No. Everything is fine. There were some issues with the ci configuration, which I (hopefully) fixed in the recent PR. That was the reason, why the Run Tests job failed. I wanted to have it fixed first. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
=======================================
Coverage 94.51% 94.52%
=======================================
Files 18 18
Lines 1313 1314 +1
=======================================
+ Hits 1241 1242 +1
Misses 37 37
Partials 35 35 ☔ View full report in Codecov by Sentry. |
dadrus
changed the title
dadrus
previously approved these changes
May 15, 2026
dadrus
approved these changes
May 15, 2026
Owner
|
@mariusor: Thank you very much! In the PR, we started with, there were some typos, you identified and fixed. Do you have some time to do that again? :) |
Contributor
Author
|
Created #113 for fixing the typos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #105
Changing the interface of the NonceChecker to take into account the presence of the nonce signature parameter