This repository was archived by the owner on Jun 6, 2019. It is now read-only.
Reduce Import Scope & Ignore Undefined Returns from Reducers#5
Open
wallzero wants to merge 4 commits into
Open
Reduce Import Scope & Ignore Undefined Returns from Reducers#5wallzero wants to merge 4 commits into
wallzero wants to merge 4 commits into
Conversation
Author
|
Nevermind this still doesn't work. If the scan returns that state it also overwrites any states called by nested reducers. |
Author
|
Tried using an || instead of storing the object but seems to only work some of the time; I'm guessing it depends on the order of the reducers in the scan. It be great if there was a way to have the scan itself skip returning an item. |
Remove handling of undefined returns from reducer
Author
|
In the end I don't think this PR is going to resolve my issue. I think handling undefined is a good practice, but it seems if I don't return (state) > state, the scan will overwrite any changes to state by nested reducers. I've removed the undefined handler and now this PR is only about scoped imports. I'll continue comments in the issue ticket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the following issue: #4