Skip to content

Add Django 5.2 and 6.0 to test matrix, remove Python 3.8 and 3.9#14

Merged
j4mie merged 3 commits into
masterfrom
django-6.0
Feb 26, 2026
Merged

Add Django 5.2 and 6.0 to test matrix, remove Python 3.8 and 3.9#14
j4mie merged 3 commits into
masterfrom
django-6.0

Conversation

@MarkBird

Copy link
Copy Markdown

Remove unsupported versions of Django and add latest.

@dabapps-robot dabapps-robot self-requested a review February 25, 2026 11:14

@dabapps-robot dabapps-robot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update overall — this PR cleanly moves the CI matrix forward with current Python/Django support and drops clearly EOL combinations.

High-level review

  • ✅ Matrix changes look sensible and aligned with the PR goal (drop old versions, add newer supported ones).
  • ✅ Excluded combinations for unsupported Python/Django pairs are a good addition.
  • ✅ Updating GitHub Actions versions in the same pass is a good maintenance win.

Minor suggestion (non-blocking)

It could be helpful to add a short comment in the workflow next to exclude explaining why those pairs are excluded (e.g. “unsupported by Django upstream”), just to make future maintenance a bit easier.

Otherwise, this looks good to me and is ready to merge.

@dabapps-robot dabapps-robot self-requested a review February 25, 2026 13:51

@dabapps-robot dabapps-robot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update — this still looks good to me and I’m happy for it to merge ✅

Only minor carry-over from my earlier note: it could still be helpful to add a brief comment next to the matrix.exclude entries in CI (e.g. “unsupported upstream combination”), just so future maintainers don’t need to re-derive why those pairs are excluded. Non-blocking.

@j4mie j4mie merged commit 6356293 into master Feb 26, 2026
11 checks passed
@j4mie j4mie deleted the django-6.0 branch February 26, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants