Skip to content

Modernise build tooling and configuration#78

Closed
MarkBird wants to merge 2 commits into
masterfrom
modernise-build-tooling
Closed

Modernise build tooling and configuration#78
MarkBird wants to merge 2 commits into
masterfrom
modernise-build-tooling

Conversation

@MarkBird

Copy link
Copy Markdown

Transition the project from the old-school setup.py style to the more modern pyproject.toml approach.

@dabapps-robot dabapps-robot self-requested a review February 25, 2026 10:18
@MarkBird MarkBird changed the title Modernise bulid tooling and configuration Modernise build tooling and configuration Feb 25, 2026

@dabapps-robot dabapps-robot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice modernisation overall 👍 — moving to pyproject.toml, switching to python -m build, and using pypa/gh-action-pypi-publish is a solid improvement and simplifies release management a lot.

A couple of things worth checking before merge:

  1. Potential compatibility mismatch (requires-python vs build backend constraint)
    In pyproject.toml, runtime support is declared as >=3.8, but build requires setuptools>=77.0.0.
    It’d be worth confirming that this setuptools floor is compatible with your stated Python support window. If not, you may want to lower the minimum setuptools version to one that still supports Python 3.8.

  2. __version__ removal from package namespace
    log_request_id.__version__ has been removed from __init__.py. If any consumers read that attribute directly, this is a small API break.
    If backward compatibility matters, consider keeping __version__ (even if canonical versioning now lives in pyproject.toml).

If those are intentional/confirmed, this looks good to merge from my side.

@MarkBird

Copy link
Copy Markdown
Author

Closing to redo with latest Django/Python versions

@MarkBird MarkBird closed this Feb 26, 2026
@MarkBird MarkBird deleted the modernise-build-tooling branch February 26, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants