Modernise build tooling and configuration#78
Conversation
dabapps-robot
left a comment
There was a problem hiding this comment.
Nice modernisation overall 👍 — moving to pyproject.toml, switching to python -m build, and using pypa/gh-action-pypi-publish is a solid improvement and simplifies release management a lot.
A couple of things worth checking before merge:
-
Potential compatibility mismatch (
requires-pythonvs build backend constraint)
Inpyproject.toml, runtime support is declared as>=3.8, but build requiressetuptools>=77.0.0.
It’d be worth confirming that this setuptools floor is compatible with your stated Python support window. If not, you may want to lower the minimum setuptools version to one that still supports Python 3.8. -
__version__removal from package namespace
log_request_id.__version__has been removed from__init__.py. If any consumers read that attribute directly, this is a small API break.
If backward compatibility matters, consider keeping__version__(even if canonical versioning now lives inpyproject.toml).
If those are intentional/confirmed, this looks good to merge from my side.
|
Closing to redo with latest Django/Python versions |
Transition the project from the old-school
setup.pystyle to the more modernpyproject.tomlapproach.