Skip to content

Modernise build tooling and configuration#14

Open
MarkBird wants to merge 1 commit into
masterfrom
modernise-build-tooling
Open

Modernise build tooling and configuration#14
MarkBird wants to merge 1 commit into
masterfrom
modernise-build-tooling

Conversation

@MarkBird

Copy link
Copy Markdown

Transition the project from the old-school setup.py style to the more modern pyproject.toml approach.

@dabapps-robot dabapps-robot self-requested a review February 26, 2026 15:25

@dabapps-robot dabapps-robot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update overall — this is a solid modernization of the packaging/release setup.

High-level

Moving from setup.py to pyproject.toml + python -m build and switching to pypa/gh-action-pypi-publish is a great simplification. The metadata looks clean, and removing the old custom packaging helpers is definitely a maintenance win.

One thing to double-check

  • __version__ removal from enforce_host.__init__
    This may be a small backwards-incompatible change for anyone doing from enforce_host import __version__.
    If that’s considered part of the public API, it may be worth keeping it (or adding a deprecation path) even though version metadata now lives in pyproject.toml.

If dropping __version__ is intentional, I think this PR is otherwise in good shape to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants