Modernise build tooling and configuration#14
Open
MarkBird wants to merge 1 commit into
Open
Conversation
dabapps-robot
left a comment
There was a problem hiding this comment.
Nice update overall — this is a solid modernization of the packaging/release setup.
High-level
Moving from setup.py to pyproject.toml + python -m build and switching to pypa/gh-action-pypi-publish is a great simplification. The metadata looks clean, and removing the old custom packaging helpers is definitely a maintenance win.
One thing to double-check
__version__removal fromenforce_host.__init__
This may be a small backwards-incompatible change for anyone doingfrom enforce_host import __version__.
If that’s considered part of the public API, it may be worth keeping it (or adding a deprecation path) even though version metadata now lives inpyproject.toml.
If dropping __version__ is intentional, I think this PR is otherwise in good shape to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transition the project from the old-school setup.py style to the more modern pyproject.toml approach.