Consolidate blocks and remove unnecessary variants#1
Merged
Conversation
- Changed header.js to load navigation from /nav instead of /content/nav - Changed footer.js to load footer from /footer instead of /content/footer - Added content/ directory to .gitignore (cloned from DA, not version controlled) Content has been moved to /nav and /footer in DA and pushed successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Merged duplicate blocks into proper EDS variant pattern: - cards + cards-story → cards block with .story variant - columns + columns-feature → columns block with .feature variant - hero + hero-banner → hero block with .banner variant Each base block now handles multiple variants via CSS classes. Duplicate folders (cards-story, columns-feature, hero-banner) should be deleted. Block usage in content should be updated: - Cards-Story → Cards (story) - Columns-Feature → Columns (feature) - Hero-Banner → Hero (banner) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove banner variant, make it the default hero style - Banner was the only style in use, no need for variant yet - Update documentation to reflect single style - Follow EDS best practice: don't create variants until needed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Delete consolidated block folders (cards-story, columns-feature, hero-banner) - Rename tabs-solutions → tabs - Rename video-feature → video - Update all class references in video block CSS and JS - Add draft test file at drafts/kiran/index.html 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove story variant from cards, make it the default style - Remove feature variant from columns, make it the default style - Fix tabs block class names (tabs-solutions → tabs) - All blocks now use simple class names without variants 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
When removing variants, accidentally removed all base CSS including critical layout properties. This restores the essential base styles: - cards: list-style, margin, padding, display grid - columns: flexbox layout, order properties, responsive rules Also removes the now-unused variant block folders. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Change tabs panel max-width from 930px to 66% for better responsiveness - Remove variant class names (story, feature) from draft content - Blocks now use default styles without variant modifiers Matches production styling with responsive width constraints. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
- Use template literals instead of string concatenation - All eslint errors resolved, only console warnings remain 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Before/After URLs
Before (main): https://main--aig--da-pilot.aem.page/
After (blocks-content): https://blocks-content--aig--da-pilot.aem.page/drafts/kiran/
🤖 Generated with Claude Code