fix: include extension fields in Invoke-D365GenerateReportDataEntityField (#649 follow-up) - #915
Open
pavankadabala-png wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #910 (issue #649), per @FH-Inway's request to also cover Invoke-D365GenerateReportDataEntityField / Get-AxDataEntities.
Invoke-D365GenerateReportDataEntityField builds its report through the internal Get-AxDataEntities, which still read each entity with DataEntityViews.Read($elementName), so fields added to an entity via extensions were omitted from the field-level report. This applies the same fix #910 made to Invoke-D365GenerateReportDataEntity, switching the read to the extension-aware ReadDataEntityViewWithExtensions call.
ExtensionMethods lives in the Microsoft.Dynamics.AX.Metadata.Storage assembly already loaded by Import-GenerateReportAssemblies, so no new dependency is introduced. This is an internal-helper change only, with no public parameter or help changes. (The diff also normalizes a missing end-of-file newline that the web editor added automatically.)
Refs #649, #910