perf(zarr-transforms): partition sorted 1-D array maps by chunk#234
Merged
d-v-b merged 1 commit intoJul 22, 2026
Merged
Conversation
d-v-b
approved these changes
Jul 21, 2026
d-v-b
merged commit Jul 22, 2026
4d35384
into
d-v-b:refactor/simplify-indexing
8 of 10 checks passed
d-v-b
added a commit
that referenced
this pull request
Jul 22, 2026
…nsforms The fast path bound 'm' as ArrayMap before the general loop rebinds it to the OutputIndexMap union, which mypy rejects (and treats the ConstantMap arm as unreachable). packages/ is outside the pre-commit mypy scope, so #234's CI could not catch this. Assisted-by: ClaudeCode:claude-fable-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the conversation here: zarr-developers#4170 (comment)
Regression check:
The speedup for this case: