-
Notifications
You must be signed in to change notification settings - Fork 21
chore(deps): update dependency rimraf to v6 #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -68,7 +68,7 @@ | |
| "karma-tap": "^4.2.0", | ||
| "nyc": "^17.0.0", | ||
| "phantomjs-prebuilt": "^2.1.3", | ||
| "rimraf": "^2.2.8", | ||
| "rimraf": "^6.0.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rimraf v6 requires Node 20 breaking declared engineHigh Severity Upgrading Reviewed by Cursor Bugbot for commit 46ccfc2. Configure here. |
||
| "server-destroy": "^1.0.1", | ||
| "standard": "^9.0.0", | ||
| "tap": "^15.1.5", | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rimraf v6 breaks
rimraf.sync()call in testsHigh Severity
Upgrading
rimraffrom^2.2.8to^6.0.0breaks the existing usage intests/test-unix.js. The test file doesvar rimraf = require('rimraf')followed byrimraf.sync(socket). In rimraf v2,require('rimraf')returned a function with a.syncproperty. In rimraf v5+, the default export was removed —require('rimraf')now returns an object with named exports like{ rimraf, rimrafSync, ... }. The.syncproperty no longer exists on the module object, sorimraf.sync(socket)will throw aTypeErrorat runtime.Additional Locations (1)
yarn.lock#L5316-L5323