fix: send server.version handshake before any ElectrumX request#1347
Merged
julian-CStack merged 1 commit intoMay 21, 2026
Merged
Conversation
navidR
force-pushed
the
dev/navidr/fix-electrumx-protocol
branch
from
a1a79e4 to
2799ebc
Compare
navidR
force-pushed
the
dev/navidr/fix-electrumx-protocol
branch
from
2799ebc to
544ea8a
Compare
julian-CStack
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updated electrumx-firo server enforces strict protocol negotiation: server.version must be the first message after connecting, or the server disconnects with BAD_REQUEST: use server.version to identify client (see electrumx-firo/src/electrumx/server/session.py:1056-1060). Without this handshake, all ElectrumX RPC calls fail immediately after connection. This patch adds a server.version request in two places — ElectrumXClient after creating a new client (before adding it to ClientManager) and in checkElectrumServer before the health-check ping — so both regular operation and connection probes satisfy the protocol requirement.