[-] fix unrecognized config parameter "pg_timetable.current_chain_id"#785
Merged
Merged
Conversation
executeOnErrorHandler did not set `pg_timetable.current_chain_id` and `current_client_name` GUCs before executing the `on_error` SQL, causing error. Fixed by opening a transaction, calling `SetCurrentTaskContext()`, then executing the error handler SQL within it.
Coverage Report for CI Build 28050185797Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-0.007%) to 89.384%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions4 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
executeOnErrorHandler()did not setpg_timetable.current_chain_idandcurrent_client_nameGUCs before executing theon_errorSQL, causing error.Fixed by opening a transaction, calling
SetCurrentTaskContext(), then executing the error handler SQL within it.