Skip to content

add bucketacl bucketpolicy multiparts-management#5

Open
cxt90730 wants to merge 4 commits into
mainfrom
add-bucketcreatetime
Open

add bucketacl bucketpolicy multiparts-management#5
cxt90730 wants to merge 4 commits into
mainfrom
add-bucketcreatetime

Conversation

@cxt90730

Copy link
Copy Markdown
Owner

No description provided.

Comment thread app/s3cmd.go Outdated
}
res.Buckets = append(res.Buckets, b)
}
runtime.LogDebug(a.ctx, "ListBuckets success.")

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless debug log

Comment thread app/s3cmd.go
return out, err
}
for _, upload := range res.Uploads{
upload1 := MultipartUpload{

@cxt90730 cxt90730 Apr 11, 2023

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upload是指针么?如果是的话upload1没有必要,直接修改res的Uploads后返回

</el-popconfirm>
</template>
</el-table-column>

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释以后不用,删了就好

Comment thread frontend/src/components/BucketList.vue Outdated
setup() {
const loading = ref(true)
let bucket = ref('')
let radio1 = ref('')

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

命名时最好知道这个radio是干啥的而不是radio1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants