Skip to content

Default paths.graph and paths.samples — no more boilerplate in config.yml#105

Merged
cweniger merged 1 commit into
mainfrom
feature/default-paths
Jun 22, 2026
Merged

Default paths.graph and paths.samples — no more boilerplate in config.yml#105
cweniger merged 1 commit into
mainfrom
feature/default-paths

Conversation

@cweniger

Copy link
Copy Markdown
Owner

Summary

  • paths.graph and paths.samples no longer need to be declared in config.yml — they default to {run_dir}/graph and {run_dir}/samples
  • All three path defaults (graph, samples, buffer) are now applied centrally in _resolve_paths instead of being scattered as or f'{run_dir}/...' fallbacks across call sites
  • logging.local.dir removed from example configs (it was being overridden in code anyway)
  • paths.graph/paths.samples removed from all four example configs

Changes

  • PathConfig.graph: MISSINGOptional[str] = None
  • _resolve_paths: applies defaults for all three paths after merge
  • api.py _DEFAULT_GRAPH_CONFIG: stripped redundant path/logging keys
  • Example configs: paths section now only needs imports

Test plan

  • 49/49 existing tests pass
  • Smoke-test falcon launch in an example dir without paths.graph/paths.samples in config

🤖 Generated with Claude Code

…ir}/samples

Users no longer need to declare paths.graph/samples in config.yml — the
defaults are applied centrally in _resolve_paths. The same fallback pattern
already used for paths.buffer and paths.samples is now used consistently for
all three paths.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@cweniger cweniger merged commit 6560353 into main Jun 22, 2026
4 checks passed
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.42%. Comparing base (2a7dd8d) to head (b67af3e).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
falcon/cli.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   10.43%   10.42%   -0.02%     
==========================================
  Files          30       30              
  Lines        3891     3896       +5     
==========================================
  Hits          406      406              
- Misses       3485     3490       +5     
Flag Coverage Δ
unit 10.42% <10.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant