fix: add missing npm install step in Dockerfile#140
Open
IIMFINE wants to merge 1 commit into
Open
Conversation
The Dockerfile was missing the npm install step, causing 'Cannot find module crypto-js' error at runtime. This adds package.json and package-lock.json copy and runs npm install before copying the rest of the application files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Dockerfile is missing the
npm installstep. This causes a runtime error:The Node.js dependencies (
crypto-js,jsdom) defined inpackage.jsonare never installed during the Docker build, so the XHS signature calculation fails at runtime.Fix
Added
COPY package.json package-lock.jsonandRUN npm install --productionbefore the finalCOPY . .step, following Docker layer caching best practices.Testing