chore(inbox): migrate messaginginbox to shared publish plugin#770
Merged
mahmoud-elmorabea merged 1 commit intoJul 6, 2026
Merged
Conversation
Rebasing feat/overlay-inbox onto main brought in #738 (adopt shared io.customer.android.publish plugin), which deleted scripts/publish-module.gradle and migrated every module to `apply plugin: 'io.customer.android.publish-module'` + `customerIoPublish { artifactId = ... }`. The messaginginbox module was created on the feature branch before #738, so the rebase left it on the removed script, aborting project evaluation before android-config.gradle set compileSdk and failing the sample-app build. Migrate it to match its siblings (e.g. messaginginapp). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/overlay-inbox #770 +/- ##
=====================================================
Coverage ? 65.45%
Complexity ? 1018
=====================================================
Files ? 173
Lines ? 5848
Branches ? 874
=====================================================
Hits ? 3828
Misses ? 1719
Partials ? 301 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
|
Build available to test |
mrehan27
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Android sample-app build failure on
feat/overlay-inboxafter it was rebased onto latestmain.Root cause:
main#738 adopted the sharedio.customer.android.publishplugin and deletedscripts/publish-module.gradle.messaginginboxwas created before #738 and still usedapply from: "${rootDir}/scripts/publish-module.gradle", which no longer exists — aborting project evaluation beforeandroid-config.gradlesetscompileSdk, so AGP failed with "project ':messaginginbox' does not specify compileSdk" and both sample apps failed to build.Fix: migrate
messaginginbox/build.gradletoapply plugin: 'io.customer.android.publish-module'+customerIoPublish { artifactId = ... }, matching every sibling module.Draft, targeting
feat/overlay-inbox. Merging this makes #769's sample-app build green.🤖 Generated with Claude Code
Note
Low Risk
Build/publishing Gradle wiring only; no runtime or API changes in the inbox module.
Overview
Fixes sample-app evaluation for
:messaginginboxafterscripts/publish-module.gradlewas removed onmain(#738).messaginginbox/build.gradlenow usesapply plugin: 'io.customer.android.publish-module'andcustomerIoPublish { artifactId = "messaging-inbox" }instead of the deletedpublish-module.gradlescript and localPUBLISH_*extproperties. Maven coordinates stay the same; only the publishing setup is aligned with sibling modules.Reviewed by Cursor Bugbot for commit 4ce8f1e. Bugbot is set up for automated code reviews on this repo. Configure here.