Replace all wildcard instances in variable names#342
Merged
Conversation
For GoCD env var can have a dynamic "material" name. E.g. `GO_SCM_*_PR_URL` or `GO_SCM_*_PR_BRANCH`. We replace this wildcard with a `.*` and then look for a matching environment variable using the resulting regex. For Java and JavaScript we only replace the first occurrence of `*`. CodeQL thinks this is probably a mistake. Though in practice there is only ever one wildcard. The other implementations also do replace all occurrences so for consistency Java and JavaScript should do the same.
mpkorstanje
force-pushed
the
javascript-fix-escapes
branch
from
9d3c37e to
c27626f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚡️ What's your motivation?
For GoCD env var can have a dynamic "material" name. E.g.
GO_SCM_*_PR_URLorGO_SCM_*_PR_BRANCH. We replace this wildcard with a.*and then look for a matching environment variable using the resulting regex.For Java and JavaScript we only replace the first occurrence of
*. CodeQL thinks this is probably a mistake. Though in practice there is only ever one wildcard.The other implementations also do replace all occurrences so for consistency Java and JavaScript should do the same.
🏷️ What kind of change is this?
📋 Checklist: