Skip to content
This repository was archived by the owner on Nov 24, 2020. It is now read-only.

Fix: Resolve problem of Block-scoped variable on cache code#54

Open
MichelRibeiro1 wants to merge 7 commits into
masterfrom
fix/renameCacheVersionVariable
Open

Fix: Resolve problem of Block-scoped variable on cache code#54
MichelRibeiro1 wants to merge 7 commits into
masterfrom
fix/renameCacheVersionVariable

Conversation

@MichelRibeiro1

@MichelRibeiro1 MichelRibeiro1 commented Jul 19, 2019

Copy link
Copy Markdown

When a method has one of these arguments: key, expirationSeconds, version, the build fails, due to a Block-scoped variable error.
error

Comment thread src/target/typescript_nodeserver.cr Outdated
Comment thread src/target/typescript_nodeserver.cr Outdated
@icaaro

icaaro commented Jul 19, 2019

Copy link
Copy Markdown
Contributor

This bug is related with #35 issue

@icaaro

icaaro commented Jul 20, 2019

Copy link
Copy Markdown
Contributor

My suggestion to solve this problem is rename the variable using _ since the sdkgen lang spec don't allow _ use in variable names, function declaration and etc .
This way its impossible has a collision with this variable At least as long as the language specification does not change.
iex _key.

@MichelRibeiro1 MichelRibeiro1 changed the title Fix/rename cache version variable Fix: Resolve problem of Block-scoped variable on cache code Jul 23, 2019
@dgadelha
dgadelha force-pushed the fix/renameCacheVersionVariable branch from c2fb305 to c8a8cbe Compare September 24, 2019 15:58
@dgadelha dgadelha closed this Sep 24, 2019
@dgadelha
dgadelha deleted the fix/renameCacheVersionVariable branch September 24, 2019 16:00
@dgadelha
dgadelha restored the fix/renameCacheVersionVariable branch September 24, 2019 16:02
@dgadelha dgadelha reopened this Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants